Reviewable status: 0 of 36 files reviewed, 1 unresolved discussion

backend/api/forms.py line 69 at r1 (raw file):

        validators=[
            RegexValidator(
                r"^[A-Z]{2}[0-9]{3}$",

validate 5 characters

Reviewable status: 0 of 36 files reviewed, 2 unresolved discussions

backend/service/settings.py line 50 at r1 (raw file):

]

ROOT_URLCONF = "service.urls"

make reusable settings

Reviewable status: 0 of 36 files reviewed, 3 unresolved discussions

backend/service/settings.py line 68 at r1 (raw file):

]

WSGI_APPLICATION = "service.wsgi.application"

reusable setting

Reviewable status: 0 of 36 files reviewed, 4 unresolved discussions

backend/service/settings.py line 83 at r1 (raw file):

# https://docs.djangoproject.com/en/3.2/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [

reusable setting

Reviewable status: 0 of 36 files reviewed, 4 unresolved discussions

backend/service/settings.py line 83 at r1 (raw file):

add TODO to create custom password validators

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @SKairinos)

.github/workflows/main.yaml line 28 at r1 (raw file):

        with:
          python-version: ${{ env.PYTHON_VERSION }}
      

Extra whitespaces

backend/api/forms.py line 69 at r1 (raw file):

Reminder

backend/api/urls.py line 15 at r1 (raw file):

                    name="login",
                ),
                path(

Is there a reason why this URL path isn't in cron like the other cron jobs are in the portal-react and portal repos?

backend/api/views.py line 59 at r1 (raw file):

        session_objects: SessionManager = Session.objects

        before_session_count = session_objects.all().count()

Learnt this just the other day but it seems like you can just do session_objects.count() and it's the same 🤷‍♂️ https://docs.djangoproject.com/en/3.2/ref/models/querysets/#count

backend/api/views.py line 66 at r1 (raw file):

        call_command("clearsessions")

        after_session_count = session_objects.all().count()

Same here

backend/service/settings.py line 50 at r1 (raw file):

Reminder

backend/service/settings.py line 68 at r1 (raw file):

Reminder

backend/service/settings.py line 83 at r1 (raw file):

Reminder

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @faucomte97)

.github/workflows/main.yaml line 28 at r1 (raw file):

Done.

backend/api/urls.py line 15 at r1 (raw file):

Yes. It's part of a larger conversation I wanted to have about we organise our backend code. Basically, I want to organise all urls to be more object-oriented and have the following naming convention:

https://www.codeforlife.education/{service_name}/{object_name}/{function_name}/

For example, to create a new Game in the kurono service:
POST https://www.codeforlife.education/kurono/game/

So because we're mutating session objects:
GET (should be post but google requires get) https://www.codeforlife.education/sso/session/clear-expired/

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @faucomte97)

backend/api/urls.py line 15 at r1 (raw file):

GET (should be DELETE but google requires GET) https://www.codeforlife.education/sso/session/clear-expired/

backend/api/views.py line 59 at r1 (raw file):

Done.

backend/api/views.py line 66 at r1 (raw file):

Done.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)